Add IgnoreIfAlreadyExists option to Create Release V6 #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grace-rehn
requested review from
HuyPhanNguyen,
IsaacCalligeros95,
benPearce1 and
hnrkndrssn
benPearce1
reviewed
Feb 14, 2025
| const response = await repository.create(command); | ||
|
|
||
| client.info(`🎉 Release ${response.ReleaseVersion} created successfully!`); | ||
| client.info(`🎉 Release ${response.ReleaseVersion} is ready for deployment!`); |
Contributor
There was a problem hiding this comment.
If the call was successful and IgnoreIfAlreadyExists is false, then we know a new one was created successfully, if it is true then we don't know what happened
Suggested change
| client.info(`🎉 Release ${response.ReleaseVersion} is ready for deployment!`); | |
| if (command.IgnoreIfAlreadyExists) { | |
| client.info(`🎉 Release ${response.ReleaseVersion} is ready for deployment!`); | |
| } else { | |
| client.info(`🎉 Release ${response.ReleaseVersion} created successfully!`); | |
| } |
benPearce1
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #333
V6 no longer supports Additional Parameter
--ignoreexisting.Add
IgnoreIfAlreadyExistsoption.Base PR #337